changefdeedccl: Unskip alter changefeed tests#106951
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 18, 2023
Merged
changefdeedccl: Unskip alter changefeed tests#106951craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
jayshrivastava
approved these changes
Jul 18, 2023
jayshrivastava
approved these changes
Jul 18, 2023
|
|
||
| // Add implements Writer interface. | ||
| func (b *blockingBuffer) Add(ctx context.Context, e Event) error { | ||
| if log.V(1) { |
Contributor
There was a problem hiding this comment.
nit: maybe use V(2) here bc it's per event?
| Value: tree.NewStrVal(string(changefeedbase.OptFormatParquet)), | ||
| }, | ||
| ) | ||
| log.Infof(context.Background(), "using parquet format; NAH") // DO NOT MERGE |
Contributor
There was a problem hiding this comment.
remember to uncomment before merging :)
Fixes cockroachdb#83946 Unskip previously skipped tests. TestAlterChangefeedInitialScan is no longer flaky. Fix TestAlterChangefeedDatabaseQualifiedNames -- the flakiness was due to the incorrect logic in test feed machinery that would erroneously skip data file. Remove TestAlterChangefeedUpdateFilter test -- as the comment says it's a test for now removed/deprecated primary_key_filter option (replaced with cdc queries). Ability to alter changefeeds with cdc query is currently on a backlog and the test will need to be re-written enterely to support that. Release note: None
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83946
Unskip previously skipped tests.
TestAlterChangefeedInitialScan is no longer flaky. Fix TestAlterChangefeedDatabaseQualifiedNames -- the flakiness was due to the incorrect logic in test feed machinery that would erroneously skip data file.
Remove TestAlterChangefeedUpdateFilter test -- as the comment says it's a test for now removed/deprecated primary_key_filter option (replaced with cdc queries). Ability to alter changefeeds with cdc query is currently on a backlog and the test will need to be re-written enterely to support that.
Release note: None