cli,server: log the initiation of shutdown more clearly#106609
cli,server: log the initiation of shutdown more clearly#106609craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
aad4c3b to
3fb0788
Compare
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @renatolabs, and @stevendanna)
Prior to this patch, the error object that triggers spontaneous shutdown and flows through the `stopTrigger` was only kept in RAM and printed at the very tail end of server shutdown (when the CLI code was exiting). This patch ensures it is logged as soon as the shutdown is triggered. It makes debugging slightly easier. Release note: None
3fb0788 to
554ff40
Compare
|
TFYR! bors r=yuzefovich |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-106609 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106665/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Epic: CRDB-26691
Helped debug issues with #96144.
Prior to this patch, the error object that triggers spontaneous shutdown and flows through the
stopTriggerwas only kept in RAM and printed at the very tail end of server shutdown (when the CLI code was exiting).This patch ensures it is logged as soon as the shutdown is triggered. It makes debugging slightly easier.
Release note: None