c2c: use shared process tenants in c2c unit tests#106560
c2c: use shared process tenants in c2c unit tests#106560craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
ad7c7b4 to
9c7f02a
Compare
23e99c8 to
7605fcb
Compare
|
unrelated test flakes |
stevendanna
left a comment
There was a problem hiding this comment.
This seems reasonable to me. Thanks!
| testTenant, destTenantConn := serverutils.StartTenant(c.T, c.DestSysServer, | ||
| base.TestTenantArgs{TenantID: c.Args.DestTenantID, DisableCreateTenant: true, SkipTenantCheck: true}) | ||
| func (c *TenantStreamingClusters) StartDestTenant(ctx context.Context) func() error { | ||
| c.DestSysSQL.Exec(c.T, `ALTER TENANT $1 START SERVICE SHARED`, c.Args.DestTenantName) |
There was a problem hiding this comment.
I wonder if it is in our interest to also grant all capabilities to the tenant here.
There was a problem hiding this comment.
I'm inclined to keep this as is for now. I took a look at our runbook(s) and our roachtests and we currently don't do any post cutover granting. I can add something in a follow up PR once we add something to the runbook around this.
There was a problem hiding this comment.
I'm fine doing it later.
The runbook doesn't have the grants because it uses a configuration profile that creates a tenant with all capabilities by default. The roachtests do grant the exmpt_from_rate_limiting capability IIRC.
7605fcb to
9d28010
Compare
For the foreseeable future, c2c will be run in a unified architecture with shared process tenants. To better reflect this production environment, this patch modifies the c2c unit test driver to use shared process tenants. Epic: none Release note: none
9d28010 to
908a369
Compare
|
TFTR! bors r=stevendanna |
|
Build succeeded: |
|
blathers backport 23.1 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 908a369 to blathers/backport-release-23.1-106560: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
For the foreseeable future, c2c will be run in a unified architecture with
shared process tenants. To better reflect this production environment, this
patch modifies the c2c unit test driver to use shared process tenants.
Epic: none
Release note: none