changefeedccl: Remove stale test#106433
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 10, 2023
Merged
Conversation
Fixes cockroachdb#75080 Removed `TestChangefeedRestartDuringBackfill` test which was previously skipped, and remaing skipped for very long time. The reason for removal is that this test is exceedingly brittle and very stale. Furthermore, the functionality of restart during backfill already test extensively by non-flaky tests that verify restart and checkpoint functionality (`TestChangefeedCheckpointSchemaChange`, `TestChangefeedBackfillCheckpoint`, `TestCoreChangefeedBackfillScanCheckpoint`). Release note: None
Member
|
This change is |
HonoreDB
approved these changes
Jul 10, 2023
Contributor
HonoreDB
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @miretskiy)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75080
Removed
TestChangefeedRestartDuringBackfilltest which was previously skipped, and remaing skipped for very long time.The reason for removal is that this test is exceedingly brittle and very stale. Furthermore, the functionality of restart during backfill already test extensively by non-flaky tests that verify restart and checkpoint functionality
(
TestChangefeedCheckpointSchemaChange,TestChangefeedBackfillCheckpoint,TestCoreChangefeedBackfillScanCheckpoint).Release note: None