sql/parser: parse CREATE PROCEDURE#106325
Conversation
|
This change is |
99c49c9 to
059e2ea
Compare
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, 49 of 49 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan, @mgartner, and @samiskin)
pkg/sql/parser/help_test.go line 576 at r1 (raw file):
{`ALTER FUNCTION ??`, `ALTER FUNCTION`}, {`DROP FUNCTION ??`, `DROP FUNCTION`},
[nit] Is this line meant to be here?
mgartner
left a comment
There was a problem hiding this comment.
Any specific renaming you had in mind?
I originally renamed everything, then reverted a few things like options that only apply to UDFs and not procedures. We could rename them anyway - whatever is less confusing.
Reviewable status:
pkg/sql/parser/help_test.go line 576 at r1 (raw file):
Previously, DrewKimball (Drew Kimball) wrote…
[nit] Is this line meant to be here?
I added the new line to separate it from the UDF statements, to follow the pattern above.
Just small things like
This sounds reasonable to me. |
|
I'll give this a look today as well. |
9a1f270 to
5843cfc
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
|
I think this might need a rebase. bors r- |
|
Canceled. |
`CREATE PROCEDURE` statements can now be parsed by the SQL parser. Currently, executing `CREATE PROCEDURE` will produce an unimplemented error. Epic: CRDB-25388 Release note: None
This commit renames UDF-related AST nodes with "function" in the name to use the more general term "routine". The term "routine" is inclusive of both UDFs and procedures (e.g., Postgres implements a `DROP ROUTINE` statement which drops both UDFs and procedures), which is fitting because we'll be using the same AST nodes for both `CREATE FUNCTION` and `CREATE PROCEDURE` statements. Release note: None
Release note: None
|
bors r+ |
|
Build succeeded: |
sql/parser: parse CREATE PROCEDURE
CREATE PROCEDUREstatements can now be parsed by the SQL parser.Currently, executing
CREATE PROCEDUREwill produce an unimplementederror.
Epic: CRDB-25388
Release note: None
sem/tree: rename function AST nodes
This commit renames UDF-related AST nodes with "function" in the name to
use the more general term "routine". The term "routine" is inclusive of
both UDFs and procedures (e.g., Postgres implements a
DROP ROUTINEstatement which drops both UDFs and procedures), which is fitting
because we'll be using the same AST nodes for both
CREATE FUNCTIONandCREATE PROCEDUREstatements.Release note: None
sem/tree: rename udf.go to create_routine.go
Release note: None