Skip to content

release-23.1: rpc: simplify VerifyDialback via circuit breakers#105626

Merged
tbg merged 1 commit intocockroachdb:release-23.1from
tbg:backport23.1-103829
Jun 28, 2023
Merged

release-23.1: rpc: simplify VerifyDialback via circuit breakers#105626
tbg merged 1 commit intocockroachdb:release-23.1from
tbg:backport23.1-103829

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Jun 27, 2023 •
edited
Loading

Backport 1/9 commits from #103829.

Follows up on a190b9f (#103829).

/cc @cockroachdb/release

Release justification: bug fix for a potential goroutine leak

Now that we have #99191, we can simplify VerifyDialback. Storing connection attempts is no longer necessary since the circuit breakers keep track of the health of the remote.

Epic: none
Release note: none

@tbg
rpc: use correct ctx in VerifyDialback
5636194 
We didn't want to derive from `MasterCtx` (which has no cancellation) in this
case.

Epic: none
Release note: None
@tbg tbg requested a review from erikgrinaker June 27, 2023 15:16
@tbg tbg requested a review from a team as a code owner June 27, 2023 15:16
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jun 27, 2023

This change is Reviewable

@tbg tbg merged commit 8e54426 into cockroachdb:release-23.1 Jun 28, 2023
@tbg tbg deleted the backport23.1-103829 branch June 28, 2023 08:26
@erikgrinaker erikgrinaker mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erikgrinaker erikgrinaker erikgrinaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v23.1.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbg @cockroach-teamcity @erikgrinaker