Skip to content

kvserver: rm TestProposalNotAcknowledgedOrReproposedAfterApplication#105622

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
tbg:rm-fool-test
Jun 28, 2023
Merged

kvserver: rm TestProposalNotAcknowledgedOrReproposedAfterApplication#105622
craig[bot] merged 1 commit intocockroachdb:masterfrom
tbg:rm-fool-test

Conversation

@tbg
Copy link
Copy Markdown
Member

@tbg tbg commented Jun 27, 2023

This test can't be salvaged and besides, hasn't been run in >1.5 years. We just
merged decent enough coverage in #105272, though.

Closes #71148.

Epic: none
Release note: None

@tbg tbg requested a review from erikgrinaker June 27, 2023 14:54
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review June 27, 2023 14:54
@tbg tbg requested a review from a team as a code owner June 27, 2023 14:54
@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 27, 2023

bors r=erikgrinaker
TFTQR!

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Build failed:

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 27, 2023

Ha, serves me right for borsing early. enableTraceDebugUseAfterFree is now unused.

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 27, 2023

bors r=erikgrinaker

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Build failed (retrying...):

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 27, 2023

bors r-

🙈

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Canceled.

@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 27, 2023

Okay waited for green CI like a good citizen.

bors r=erikgrinaker

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Build failed (retrying...):

@yuzefovich
Copy link
Copy Markdown
Member

Needs an update:

[22:24:02][Run unit tests] pkg/kv/kvserver/replica_test.go:8131:3: undefined: skip
[22:24:02][Run unit tests] pkg/kv/kvserver/replica_test.go:8276:3: undefined: skip

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 27, 2023

Canceled.

This test can't be salvaged and besides, hasn't been run in >1.5 years. We just
merged decent enough coverage in cockroachdb#105272, though.

Closes cockroachdb#71148.

Epic: none
Release note: None
@tbg
Copy link
Copy Markdown
Member Author

tbg commented Jun 28, 2023

bors r=erikgrinaker

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 28, 2023

Build succeeded:

@craig craig bot merged commit ed57088 into cockroachdb:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kv: TestProposalNotAcknowledgedOrReproposedAfterApplication is fooling itself, skipped

4 participants