concurrency: small bug fix#105562
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 26, 2023
Merged
Conversation
Member
|
This change is |
nvb
approved these changes
Jun 26, 2023
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/concurrency/testdata/lock_table/clear_finalized_txn_locks line 1074 at r1 (raw file):
start-waiting: true # Consequently, req18 should be able to become a reservation holder on lock "a".
s/reservation holder/distinguished waiter/?
Previously, as seen in the testing diff, an inactive waiter/claimant on a lock could continue to remain a distinguished waiter on that lock. This is now fixed. Epic: none Release note: None
26c8565 to
22ca916
Compare
arulajmani
commented
Jun 26, 2023
Collaborator
Author
arulajmani
left a comment
There was a problem hiding this comment.
TFTR!
bors r=nvanbenschoten
Reviewable status:
pkg/kv/kvserver/concurrency/testdata/lock_table/clear_finalized_txn_locks line 1074 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
s/reservation holder/distinguished waiter/?
Yup, 🤦♂️
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, as seen in the testing diff, an inactive waiter/claimant on a lock could continue to remain a distinguished waiter on that lock. This is now fixed.
Epic: none
Release note: None