sqltelemetry: add missing schema telemetry#105482
sqltelemetry: add missing schema telemetry#105482craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
30126c0 to
82f8a3e
Compare
CREATE [ SCHEMA | INDEX | FUNCTION | TYPE ] and ALTER FUNCTION did not have any telemetry, but they should. Release note: None
82f8a3e to
032a3f7
Compare
| begin transaction #1 | ||
| # begin StatementPhase | ||
| checking for feature: CREATE INDEX | ||
| increment telemetry for sql.schema.create_index |
There was a problem hiding this comment.
Do we also want to bump this counter when creating an index as a side effect of certain ADD COLUMN statements? There are arguments both for and against and ultimately it's up to the consumers of this data to opine. In any case don't let this hold up merging this change, which is a strict improvement over the status quo.
There was a problem hiding this comment.
i think i'll leave it separate, since those are currently tracked with a call to b.IncrementSchemaChangeAlterCounter
|
tftr! bors r=postamar |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 032a3f7 to blathers/backport-release-22.2-105482: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from 032a3f7 to blathers/backport-release-23.1-105482: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
CREATE [ SCHEMA | INDEX | FUNCTION | TYPE ] and ALTER FUNCTION did not
have any telemetry, but they should.
Epic: None
Release note: None