pgrepl: allow logging in with replication parameter#105400
pgrepl: allow logging in with replication parameter#105400craig[bot] merged 1 commit intocockroachdb:masterfrom
replication parameter#105400Conversation
|
This change is |
a9a2928 to
c6728de
Compare
rafiss
left a comment
There was a problem hiding this comment.
lgtm! just a small comment
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/pgwire/pre_serve_options.go line 97 at r1 (raw file):
case "replication": // See session variable comment for the reason behind the remapping.
nit: could you change to "behind the error remapping" -- took me a while to understand this comment.
pkg/sql/pgrepl/pgrepl_test.go line 35 at r1 (raw file):
func TestMain(m *testing.M) { securityassets.SetLoader(securitytest.EmbeddedAssets) serverutils.InitTestServerFactory(server.TestServerFactory)
nit: add the leaktest auto generate thingo?
otan
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/pgwire/pre_serve_options.go line 97 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
nit: could you change to "behind the error remapping" -- took me a while to understand this comment.
i've replaced it with an actual comment.
|
Previously, otan (Oliver Tan) wrote…
sorry, i mean a full comment* |
d5edb4e to
f1c861b
Compare
|
bors r=rafiss |
|
Build failed: |
This commit adds the `replication=database` connection parameter, which enables certain replication commands to be run. See: https://www.postgresql.org/docs/current/protocol-replication.html We do this by making it a session variable instead of a parameter on the connection like PG does. This adds a hidden `replication` connection parameter to accomplish this. Release note: None
f1c861b to
569669c
Compare
|
bors r=rafiss |
|
Build succeeded: |
This commit adds the
replication=databaseconnection parameter, which enables certain replication commands to be run.See: https://www.postgresql.org/docs/current/protocol-replication.html
We do this by making it a session variable instead of a parameter on the connection like PG does. This adds a hidden
replicationconnection parameter to accomplish this.Informs: #105130
Release note: None