sql: implement pg_lsn operations#105326
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 26, 2023
Merged
Conversation
Release note (sql change): Add the ability to add numeric values to LSNs, or sub a decimal value from a LSN.
Member
|
This change is |
35 tasks
Release note (sql change): Implement the `pg_lsn - pg_lsn = decimal` builtin, which subtracts 2 LSNs to return a decimal.
ZhouXing19
approved these changes
Jun 26, 2023
Collaborator
ZhouXing19
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
Contributor
Author
|
bors r=zhouxing19 |
Contributor
|
Build succeeded: |
This was referenced Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sql: add pg_lsn +- decimal operations
Release note (sql change): Add the ability to add numeric values to
LSNs, or sub a decimal value from a LSN.
tree: implement lsn - lsn operation
Release note (sql change): Implement the
pg_lsn - pg_lsn = decimalbuiltin, which subtracts 2 LSNs to return a decimal.
Informs #105130