kvserver: rename RaftMessageHandler to IncomingRaftMessageHandler#105123
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 26, 2023
Merged
kvserver: rename RaftMessageHandler to IncomingRaftMessageHandler#105123craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
029a7a8 to
35676af
Compare
6a60f67 to
05c794f
Compare
tbg
approved these changes
Jun 20, 2023
Contributor
Author
|
I’m putting the PR merging on hold until we settle down the discussion on renaming for Listen and Stop. Update: decided to just rename Listen and Stop as well |
kvoli
approved these changes
Jun 22, 2023
Contributor
kvoli
left a comment
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @wenyihu6)
The commit renames `RaftMessageHandler`, `Listen`, and `Stop` to `IncomingRaftMessageHandler`, `ListenIncomingRaftMessages`, and `StopIncomingRaftMessages`. Another PR is introducing a new interface `OutgoingRaftMessageHandler`, dedicated to managing messages sent. The main purpose of this PR is to make the future PR cleaner by handling the renaming process. Note that this commit does not change any existing functionality. Part of: cockroachdb#103983 Related: cockroachdb#105122 Release Note: None
tbg
approved these changes
Jun 26, 2023
Contributor
Author
|
TFTRs!! bors r=tbg,kvoli |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit renames
RaftMessageHandler,Listen, andStoptoIncomingRaftMessageHandler,ListenIncomingRaftMessages, andStopIncomingRaftMessages. Another PR is introducing a new interfaceOutgoingRaftMessageHandler, dedicated to managing messages sent. The mainpurpose of this PR is to make the future PR cleaner by handling the renaming
process. Note that this commit does not change any existing functionality.
Part of: #103983
Related: #105122
Release Note: None