rpc: avoid possible deadlock on Quiesce#104945
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 16, 2023
Merged
Conversation
If a probe exited due to quiescing, previously it would not signal `c.connFuture`. But if a caller was sitting on `c.ConnectNoBreaker`, it would never get signaled as a result, which could lead to deadlocks during quiesce (as observed in CI). The future is now always signaled with an error if the probe refuses to start or exits due to the stopper quiescing. No release note since bug in no release.
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Contributor
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Member
Author
|
Commit not found, etc, something broke in bors, not a test failure. bors r+ |
Contributor
|
Build failed: |
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a probe exited due to quiescing, previously it would not signal
c.connFuture. But if a caller was sitting onc.ConnectNoBreaker, it wouldnever get signaled as a result, which could lead to deadlocks during quiesce (as observed in CI).
The future is now always signaled with an error if the probe refuses to start or
exits due to the stopper quiescing.
No release note since bug in no release.
Epic: None