opt: resolve TupleStars in UDFs and views#104929
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 15, 2023
Merged
opt: resolve TupleStars in UDFs and views#104929craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Star expressions have been allowed in UDFs since cockroachdb#95710 and in views since cockroachdb#97515. This commit lifts a restriction that prevented table references from being resolved as TupleStars in SELECT lists inside UDFs and views. For example, an expression like `SELECT tbl FROM tbl` is now allowed inside views and UDFs. Fixes cockroachdb#104927 Release note (sql change): Table names are now allowed in SELECT lists inside view and UDF definitions.
ffeef8d to
afa92a0
Compare
rharding6373
approved these changes
Jun 15, 2023
Collaborator
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
Contributor
Author
Yes! Thanks for pointing it out. bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Star expressions have been allowed in UDFs since #95710 and in views
since #97515. This commit lifts a restriction that prevented table
references from being resolved as TupleStars in SELECT lists inside UDFs
and views. For example, an expression like
SELECT tbl FROM tblis nowallowed inside views and UDFs.
Fixes #104927
Fixes #97602
Release note (sql change): Table names are now allowed in SELECT lists
inside view and UDF definitions.