kvnemesis: add TestingKnobs.OnRangeSpanningNonTxnalBatch back#104867
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 14, 2023
Merged
kvnemesis: add TestingKnobs.OnRangeSpanningNonTxnalBatch back#104867craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
cockroachdb#103963 accidentally removed a testing knob which caused cockroachdb#104865. This commit adds the testing knob back. Fixes: cockroachdb#104865 Release note: none
tbg
reviewed
Jun 14, 2023
Member
tbg
left a comment
There was a problem hiding this comment.
Looks good!
I wouldn't usually do this right away, but since the code change is so small and I think the tests will be pretty flaky without this:
bors r+
Contributor
|
👎 Rejected by too few approved reviews |
tbg
approved these changes
Jun 14, 2023
Member
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103963 accidentally removed a testing knob which caused #104865.
This commit adds the testing knob back.
Fixes: #104865
Release note: none