backupccl: unskip TestIngest#104715
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 12, 2023
Merged
Conversation
The issue here was that we recently added a log.Scope(t).Close(t) call to this test. However, log.Scope(t) creates a goroutine that is only cleaned up when the defer is called. As a result a leaktest inside the given subtests failed. Here, we move the log scope into the subtest as well. Fixes cockroachdb#104639 Release note: None
Member
|
This change is |
msbutler
approved these changes
Jun 12, 2023
Collaborator
Author
|
bors r=msbutler |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue here was that we recently added a log.Scope(t).Close(t) call to this test. However, log.Scope(t) creates a goroutine that is only cleaned up when the defer is called. As a result a leaktest inside the given subtests failed.
Here, we move the log scope into the subtest as well.
Fixes #104639
Release note: None