storage: Don't add NoopRequests to the command queue#10470
Merged
bdarnell merged 2 commits intocockroachdb:masterfrom Nov 6, 2016
Merged
storage: Don't add NoopRequests to the command queue#10470bdarnell merged 2 commits intocockroachdb:masterfrom
bdarnell merged 2 commits intocockroachdb:masterfrom
Conversation
Contributor
|
Reviewed 1 of 1 files at r1, 3 of 3 files at r2. Comments from Reviewable |
Member
|
Reviewed 1 of 1 files at r1, 3 of 3 files at r2. Comments from Reviewable |
petermattis
reviewed
Nov 5, 2016
| count := 0 | ||
| cq.tree.Do(func(i interval.Interface) bool { | ||
| c := i.(*cmd) | ||
| keys = append(keys, fmt.Sprintf("%s-%s", roachpb.Key(c.key.Start), roachpb.Key(c.key.End))) |
Collaborator
There was a problem hiding this comment.
keys.PrettyPrintRange?
This has nicer error reporting without including test numbers in every message.
Doing so was creating unnecessary contention in the command queue for the empty key.
f27f2dc to
7250330
Compare
Contributor
Author
|
Tests still pass with proposer-evaluated-kv. keys.PrettyPrintRange would require a larger refactoring of commandQueue.String than I feel like undertaking at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing so was creating unnecessary contention in the command queue for the empty key.
Discovered during investigation of #10427
This change is