Skip to content

configprofiles: deflake TestDataDriven#104501

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20230607-deflake-test
Jun 7, 2023
Merged

configprofiles: deflake TestDataDriven#104501
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20230607-deflake-test

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Jun 7, 2023

Informs #104500.
Fixes #102408.

This test was experiencing a failure due to a race condition. The root cause is described in issue #104500 and will be addressed separately. This change ensures that the test does not encounter the code path at all.

Release note: None

This test was experiencing a failure due to a race condition.
The root cause is described in issue cockroachdb#104500 and will be addressed
separately. This change ensures that the test does not encounter the
code path at all.

Release note: None
@knz knz added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Jun 7, 2023
@knz knz requested a review from stevendanna June 7, 2023 14:16
@knz knz requested review from a team as code owners June 7, 2023 14:16
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jun 7, 2023

TFYR

bors r=itsbilal

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 7, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 7, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jun 7, 2023

bors r=itsbilal

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 7, 2023

Build succeeded:

@craig craig bot merged commit 502b113 into cockroachdb:master Jun 7, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jun 7, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-104501 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/104541/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configprofiles: TestDataDriven failed

3 participants