changefeedccl: fix rolling restart test#103903
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 26, 2023
Merged
Conversation
Member
|
This change is |
0b83fbd to
b8cabd7
Compare
miretskiy
approved these changes
May 25, 2023
Previously, this test would deadlock due to it waiting for the wrong checkpoint. Now the test correctly waits for a checkpoint greater than `beforeInsert` before waiting for a highwater greater than `beforeInsert`. This tests also wraps channel sends and receives with `select` statements so, if ever required, the test can explicitly fail with a timeout instead of deadlocking. Release note: None Epic: None Closes: cockroachdb#103791
b8cabd7 to
10c1682
Compare
Contributor
Author
|
bors r=miretskiy |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this test would deadlock due to it waiting for the wrong checkpoint. Now the test correctly waits for a checkpoint greater than
beforeInsertbefore waiting for a highwater greater thanbeforeInsert.This tests also wraps channel sends and receives with
selectstatements so, if ever required, the test can explicitly fail with a timeout instead of deadlocking.Release note: None
Epic: None
Closes: #103791