go.mod: bump Pebble to 6f2788660198, rework shared storage wrapper#103538
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
6f278866 shared: improve interface for more efficient reading 9eb2c407 db: log events to testing.T in unit tests f32e7dc6 db: add reserved Pebblev4 sstable format 5a6b91b8 objstorage: improve test and add read ahead test 2bc4319e objstorage: remove genericFileReadable 8143ffb9 objstorage: fix readaheadState initialization 06d08888 db: add Compact.Duration metric e7213de0 db: add Uptime metric e9005aed db: don't delete files during ingest application 222b43ec internal/arenaskl: fix Skiplist doc typo Release note: None Epic: none
6f56d49 to
bc9288d
Compare
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @itsbilal and @RaduBerinde)
pkg/storage/shared_storage.go line 51 at r2 (raw file):
n += nn } atomic.AddInt64(&r.p.sharedBytesRead, int64(len(p)))
if we return up above, we may have read more than 0 bytes before returning. is it worth still incrementing sharedBytesRead in that case?
|
Previously, jbowens (Jackson Owens) wrote…
Could go either way here.. but any partial reads are not useful to the caller |
|
bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
6f278866 shared: improve interface for more efficient reading
9eb2c407 db: log events to testing.T in unit tests
f32e7dc6 db: add reserved Pebblev4 sstable format
5a6b91b8 objstorage: improve test and add read ahead test
2bc4319e objstorage: remove genericFileReadable
8143ffb9 objstorage: fix readaheadState initialization
06d08888 db: add Compact.Duration metric
e7213de0 db: add Uptime metric
e9005aed db: don't delete files during ingest application
222b43ec internal/arenaskl: fix Skiplist doc typo
Release note: None
Epic: none