concurrency: rollback ignored sequence numbers on lock acquisition#103493
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 19, 2023
Merged
concurrency: rollback ignored sequence numbers on lock acquisition#103493craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7a16a81 to
a778ca0
Compare
nvb
approved these changes
May 18, 2023
Contributor
nvb
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained
This patch adds logic to prune the list of sequence numbers tracked by the lock table for unreplicated locks. This is done when some of the tracked sequence numbers are considered ignored, by virtue of a savepoint rollback. Note that we only do so for unreplicated locks, and only if an unreplicated lock is being reacquired. This is because the in-memory lock table is only the source of truth for in-memory locks; the mvcc keyspace is the source of truth for replicated ones. As such, trying to mimic the logic is hard/error-prone -- so we don't attempt to do so. Fixes cockroachdb#102269 Release note: None
a778ca0 to
9e78b0a
Compare
Collaborator
Author
|
TFTR! bors r=nvanbenschoten |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds logic to prune the list of sequence numbers tracked by
the lock table for unreplicated locks. This is done when some of the
tracked sequence numbers are considered ignored, by virtue of a
savepoint rollback.
Note that we only do so for unreplicated locks, and only if an
unreplicated lock is being reacquired. This is because the in-memory
lock table is only the source of truth for in-memory locks; the mvcc
keyspace is the source of truth for replicated ones. As such, trying
to mimic the logic is hard/error-prone -- so we don't attempt to do
so.
Fixes #102269
Release note: None