Skip to content

cli: remove old workaround#103284

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
9bany:master
May 17, 2023
Merged

cli: remove old workaround#103284
craig[bot] merged 1 commit intocockroachdb:masterfrom
9bany:master

Conversation

@9bany
Copy link
Copy Markdown
Contributor

@9bany 9bany commented May 15, 2023 •
edited by tbg
Loading

Fixes #74133.

Epic: None
Release note: None

@9bany 9bany requested a review from a team May 15, 2023 11:24
@9bany 9bany requested a review from a team as a code owner May 15, 2023 11:24
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented May 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented May 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label May 15, 2023
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented May 15, 2023

This change is Reviewable

@dhartunian dhartunian requested a review from tbg May 16, 2023 15:04
@9bany @tbg
cli: remove old workaround
20d2762 
Fixes cockroachdb#74133.

Epic: None
Release note: None
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented May 16, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@tbg tbg changed the title fix: remove ReceEnabled for workaround in debug_zip cli: remove old workaround May 16, 2023
@tbg
Copy link
Copy Markdown
Member

tbg commented May 16, 2023

Hello hello! Looks good, I added some fixes and will merge on green. Thanks!

@tbg
Copy link
Copy Markdown
Member

tbg commented May 17, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 17, 2023

👎 Rejected by too few approved reviews

@dhartunian
Copy link
Copy Markdown
Collaborator

dhartunian commented May 17, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 17, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 17, 2023

Timed out.

@tbg
Copy link
Copy Markdown
Member

tbg commented May 17, 2023

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 17, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 17, 2023

Build succeeded:

@craig craig bot merged commit 6d52151 into cockroachdb:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhartunian dhartunian dhartunian approved these changes

@tbg tbg Awaiting requested review from tbg

Assignees

No one assigned

Labels

O-community Originated from the community

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cli: remove a workaround when taking profile in debug zip

4 participants

@9bany @cockroach-teamcity @tbg @dhartunian