ui: refactor txns pages to use generic RequestState#102029
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom May 8, 2023
Merged
ui: refactor txns pages to use generic RequestState#102029craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
42bcb2a to
b62de50
Compare
This commit refactors the txn fingerprints page component and its redux store wrappers to use the new RequestState. This allows us to nicely pass the entire request state to the component instead of destructuring the response into individual props. Related selectors are deleted. Epic: none Release note: None
This commit Replaces the request state props (isDataValid, statements, transaction, error, isLoading) in the txn details page with a single prop containing the request state. The logic that was previously in the selectTransaction (and being duplicated in db-console and CC) has been moved to a new file, `transactionDetailsUtils` with added unit testing. Epic: none Release note: None
b62de50 to
43b9763
Compare
maryliag
approved these changes
May 8, 2023
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Nit: Even if there are several commits, is still better to add all the info to the PR description, so all the information is in one place for reviewers to see.
Reviewed 9 of 11 files at r1, 2 of 2 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
Contributor
Author
|
tftr! |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1
ui: refactor txns page to use generic RequestState
This commit refactors the txn fingerprints page component
and its redux store wrappers to use the new RequestState.
This allows us to nicely pass the entire request state to
the component instead of destructuring the response into
individual props. Related selectors are deleted.
Epic: none
Release note: None
Commit 2
ui: refactor txn details page to use RequestState typed prop
This commit Replaces the request state props (isDataValid, statements,
transaction, error, isLoading) in the txn details page with a single
prop containing the request state.
The logic that was previously in the selectTransaction (and being
duplicated in db-console and CC) has been moved to a new file,
transactionDetailsUtilswith added unit testing.Release note: None
Epic: CRDB-25476