sql: add issue number to todo#101935
Conversation
|
This change is |
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @rharding6373)
pkg/sql/logictest/testdata/logic_test/udf_star line 198 at r1 (raw file):
ALTER TABLE t_twocol ALTER b TYPE FLOAT; # TODO(101934): Postgres allows column renaming when only referenced by UDFs.
nit: I think we usually include # sign with the issue number.
Epic: none Informs: cockroachdb#101934 Release note: none
ad7f8be to
62b5bf9
Compare
rharding6373
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/logictest/testdata/logic_test/udf_star line 198 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: I think we usually include
#sign with the issue number.
Old habits die hard :-/ It looks like the five other instances of this in the code base were probably added by me, so I just fixed them all in this PR.
|
bors r+ |
|
Build succeeded: |
Epic: none
Informs: #101934
Release note: none