util/intsets: fix test-only Fast#101908
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 20, 2023
Merged
Conversation
In cockroachdb#90009, `x/tools/Sparse` was replaced by a new `Sparse` integer set library. In that commit we forgot to update the test-only implementation of `Fast` to use the new library correctly. This was not caught earlier because CI and roachtests are not run with the `fast_int_set_small` and `fast_int_set_large` build tags. Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rytaft
approved these changes
Apr 20, 2023
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #90009,
x/tools/Sparsewas replaced by a newSparseinteger setlibrary. In that commit we forgot to update the test-only implementation
of
Fastto use the new library correctly. This was not caught earlierbecause CI and roachtests are not run with the
fast_int_set_smallandfast_int_set_largebuild tags.Epic: None
Release note: None