Skip to content

sql: add crdb_internal.pretty_value#101825

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:crdb-internal-pretty-value
May 9, 2023
Merged

sql: add crdb_internal.pretty_value#101825
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:crdb-internal-pretty-value

Conversation

@stevendanna
Copy link
Copy Markdown
Collaborator

This composes nicely with crdb_internal.scan to allow inspection of table data and other command line tools like cockroach debug pebble.

Epic: none

Release note: None

@stevendanna stevendanna requested review from a team and Xiang-Gu April 19, 2023 11:51
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@stevendanna stevendanna requested a review from msbutler April 19, 2023 11:51
This composes nicely with crdb_internal.scan to allow inspection of
table data and other command line tools like cockroach debug pebble.

Epic: none

Release note: None

Co-authored-by: Xiang Gu <xiang@cockroachlabs.com>
@stevendanna stevendanna force-pushed the crdb-internal-pretty-value branch from 958dea9 to b4bfe1a Compare May 9, 2023 09:59
Copy link
Copy Markdown
Contributor

@Xiang-Gu Xiang-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for realizing this utility! Now, with scan, pretty_key, and pretty_value, we can inspect kv pairs of a table/index in a human-readable format!

@stevendanna
Copy link
Copy Markdown
Collaborator Author

bors r=Xiang-Gu,msbutler

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 9, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 9, 2023

Build succeeded:

@craig craig bot merged commit f614c52 into cockroachdb:master May 9, 2023
@msbutler
Copy link
Copy Markdown
Collaborator

@stevendanna is it worth backporting this to 23.1 and 22.2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants