Skip to content

keyvisjob: mark the keyvis job as idle when it is not doing useful work#101750

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
zachlite:230418.idle-keyvis-job
Apr 18, 2023
Merged

keyvisjob: mark the keyvis job as idle when it is not doing useful work#101750
craig[bot] merged 1 commit intocockroachdb:masterfrom
zachlite:230418.idle-keyvis-job

Conversation

@zachlite
Copy link
Copy Markdown
Contributor

Resolves #101539
Epic: none
Release note: None

@zachlite zachlite requested a review from adityamaru April 18, 2023 14:54
@zachlite zachlite added backport-23.1.0 backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only labels Apr 18, 2023
@zachlite
Copy link
Copy Markdown
Contributor Author

cc @tbg

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Should we backport this?

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 18, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@zachlite
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 18, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

keyvisjob: key visualizer job should set MarkIdle to true

3 participants