ui: update side nav and titles to match#101706
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 18, 2023
Merged
Conversation
Member
|
This change is |
Previously the values for Advanced Debug (side nav) and Advanced Debugging (page title) were not matching. This commit uses the name "`Advanced Debug` for both. Similarly, we were using Network Latency on the side nav and Network Diagnostics on the page title. Since we might want to show more than just latency, this commit updates the title to the more generic `Network`, to match how we name other pages (e.g. SQL Activity, Database, etc). This commit also removed an extra space on the filter on the Network page. Epic: none Release note (ui change): Update Network Latency side nav name and Network Diagnostics page title to `Network`. Update the Advanced Debugging page title to `Advanced Debug`.
THardy98
approved these changes
Apr 18, 2023
THardy98
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @dongniwang and @kevin-v-ngo)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This was referenced Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the values for Advanced Debug (side nav) and Advanced Debugging (page title) were not matching. This commit uses the name "
Advanced Debugfor both.Similarly, we were using Network Latency on the side nav and Network Diagnostics on the page title. Since we might want to show more than just latency, this commit updates the title to the more generic
Network, to match how we name other pages (e.g. SQL Activity, Database, etc).This commit also removed an extra space on the filter on the Network page.
Before
After
Epic: none
Release note (ui change): Update Network Latency side nav name and Network Diagnostics page title to
Network. Update the Advanced Debugging page title toAdvanced Debug.