ui: add trace rate option to stmt diagnostics#101381
ui: add trace rate option to stmt diagnostics#101381craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
Fixes cockroachdb#92415 Add option to select the trace rate for statement diagnostics collection directly on the Console. Release note (ui change): Add option to select the trace rate for statement diagnostics collection.
5afdb18 to
8842795
Compare
THardy98
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/cluster-ui/src/api/statementDiagnosticsApi.ts line 92 at r1 (raw file):
args.push(samplingProbability); } else { args.push(0);
Not sure if we want to allow sampling probability of 0, wouldn't this never sample?
Or is 0 a special value that means "always sample" until we get the statement diagnostics bundle?
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/api/statementDiagnosticsApi.ts line 92 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
Not sure if we want to allow sampling probability of 0, wouldn't this never sample?
Or is 0 a special value that means "always sample" until we get the statement diagnostics bundle?
the 0 is what the function expects, but when you passed it actually uses NULL. You can see in the loom some cases with NULL. When we have NULL the sampling is actually 100%
THardy98
left a comment
There was a problem hiding this comment.
Reviewable status:
|
TFTR! |
|
Build succeeded: |
|
blathers backport 22.2 |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 8842795 to blathers/backport-release-22.2-101381: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #92415
Add option to select the trace rate for statement
diagnostics collection directly on the Console.
https://www.loom.com/share/beaf1ce16f7d4efc845056e33cb3bee1
Release note (ui change): Add option to select the trace rate for statement diagnostics collection.