Skip to content

sql: also support SET DEFAULT_TRANSACTION_ISOLATION.#10087

Merged
knz merged 1 commit intocockroachdb:masterfrom
knz:set-txn-level
Oct 19, 2016
Merged

sql: also support SET DEFAULT_TRANSACTION_ISOLATION.#10087
knz merged 1 commit intocockroachdb:masterfrom
knz:set-txn-level

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Oct 19, 2016 •
edited by rjnn
Loading

Required by psycopg2.

Fixes #10032.

@alamaison can you please also run a quick check that this fix indeed solves your problem. I don't have a psycopg2 client ready to test this. (But I did test using psql as you suggested.)

This change is Reviewable

alamaison
alamaison reviewed Oct 19, 2016
View reviewed changes
pkg/sql/testdata/txn Outdated
Copy link
Copy Markdown

@alamaison alamaison Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to keep testing both variants.

@alamaison
Copy link
Copy Markdown

alamaison commented Oct 19, 2016

I'll try to test the fix. I've never compiled cockroach before so please bear with me

@madelynnblue
Copy link
Copy Markdown
Contributor

madelynnblue commented Oct 19, 2016

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

pkg/sql/testdata/txn, line 426 at r1 (raw file):

Previously, alamaison wrote…

It might be a good idea to keep testing both variants.

I concur.

Comments from Reviewable

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Oct 19, 2016

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

pkg/sql/testdata/txn, line 426 at r1 (raw file):

Previously, mjibson (Matt Jibson) wrote…

I concur.

Please check the 30 lines above this snippet. The test for the previous variant is still there.

Comments from Reviewable

@madelynnblue
Copy link
Copy Markdown
Contributor

madelynnblue commented Oct 19, 2016

:lgtm:

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

Comments from Reviewable

@knz knz merged commit c67208a into cockroachdb:master Oct 19, 2016
@knz knz deleted the set-txn-level branch October 19, 2016 20:05
@alamaison alamaison mentioned this pull request Oct 20, 2016
Merged
@alamaison
Copy link
Copy Markdown

alamaison commented Oct 20, 2016

I confirm this PR fixed it. I can change isolation level using psycopg2 now.

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Oct 20, 2016

nice, glad it helped.

@jordanlewis jordanlewis mentioned this pull request Jun 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alamaison alamaison alamaison left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@madelynnblue madelynnblue

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changing isolation level with psycopg2 doesn't work

3 participants

@knz @alamaison @madelynnblue