Skip to content

contextutil: teach TimeoutError to redact only the operation name#100741

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:small.timeout-safe
Apr 6, 2023
Merged

contextutil: teach TimeoutError to redact only the operation name#100741
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:small.timeout-safe

Conversation

@andreimatei
Copy link
Copy Markdown
Contributor

Before this patch, the whole message of TimeoutError was redacted in logs. Now, only the operation name is.

Release note: None
Epic: None

Before this patch, the whole message of TimeoutError was redacted in
logs. Now, only the operation name is.

Release note: None
Epic: None
@andreimatei andreimatei requested review from a team and knz April 5, 2023 18:19
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@knz knz added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Apr 6, 2023
@andreimatei
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 6, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants