c2c: clean up ReplicationFeed error handling#100731
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 20, 2023
Merged
c2c: clean up ReplicationFeed error handling#100731craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Collaborator
Author
|
@adityamaru @miretskiy y'all seem to be the lucky ducks closest to the code while Steven and Lidor are OOO. This is low priority, and can wait until Steven is back next week. |
2d145df to
c780fc6
Compare
ed3ac29 to
5051370
Compare
Previously, the replicationFeed test helper had methods that would swallow errors, making it impossible to debug certain test failures. This patch cleans up the internals of this test helper and prevents error swallowing. Fixes cockroachdb#100414 Release note: None
5051370 to
8571abc
Compare
lidorcarmel
approved these changes
Apr 20, 2023
Collaborator
Author
|
TFTR ! bors r=lidorcarmel |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the replicationFeed test helper had methods that would swallow errors, making it impossible to debug certain test failures. This patch cleans up the internals of this test helper and prevents error swallowing.
Fixes #100414
Release note: None