upgrades: use TestingBinaryMinSupportedVersion in tests#100726
upgrades: use TestingBinaryMinSupportedVersion in tests#100726craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
0757303 to
c2090a5
Compare
ajwerner
left a comment
There was a problem hiding this comment.
Needs some bazel generation. You have my stamp when CI is green.
Reviewed 10 of 11 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan, @herkolategan, and @srosenberg)
f374f6b to
166e85c
Compare
|
bors r+ |
1 similar comment
|
bors r+ |
|
Merge conflict. |
As described in cockroachdb#100552, it's important for this API to use TestingBinaryMinSupportedVersion in order to correctly bootstrap on the older version. Removed TestFixUserfileRelatedDescriptorCorruptionUpgrade and TestPreconditionBeforeStartingAnUpgrade since they are for 22.2 migrations. Release note: None
166e85c to
2ebc229
Compare
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 2ebc229 to blathers/backport-release-23.1-100726: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
As described in #100552, it's important for this API to use TestingBinaryMinSupportedVersion in order to correctly bootstrap on the older version.
informs #100552
Release note: None