kv: deflake BenchmarkMVCCGCWithForegroundTraffic#100661
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Apr 7, 2023
Merged
kv: deflake BenchmarkMVCCGCWithForegroundTraffic#100661craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
The testContext-style tests do not have sufficient dependencies to construct a SpanConfigSubscriber. To avoid a panic in subscribedToSpanConfigs in these cases, we return false. This has the effect of disabling the StoreRebalancer. Release note: None
Fixes cockroachdb#96266. The test became flaky after cockroachdb#89632, which made it possible for single-replica tests to see the effects of pre-application raft proposal acks. This was tripping up the MVCC GC in this benchmark, leading to `request to GC non-deleted, latest value of "test"` errors. Release note: None
Member
|
This change is |
irfansharif
approved these changes
Apr 6, 2023
Contributor
Author
|
TFTR! bors r=irfansharif |
Collaborator
|
bors r- |
Contributor
|
Canceled. |
Collaborator
|
bors r=irfansharif |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96266.
The test became flaky after #89632, which made it possible for single-replica tests to see the effects of pre-application raft proposal acks. This was tripping up the MVCC GC in this benchmark, leading to
request to GC non-deleted, latest value of "test"errors.Release note: None