Skip to content

upgrades: deflake TestMigrationWithFailures#100644

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-upgrade-tests
Apr 4, 2023
Merged

upgrades: deflake TestMigrationWithFailures#100644
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-upgrade-tests

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

@ajwerner ajwerner commented Apr 4, 2023

We need to properly inject the bootstrap version, and we need to not step through too many version or enable any version gates.

Fixes #98564
Fixes #98991

Release note: None

We need to properly inject the bootstrap version, and we need to
not step through too many version or enable any version gates.

Fixes cockroachdb#98564
Informs cockroachdb#98991

Release note: None
@ajwerner ajwerner requested review from a team and rafiss April 4, 2023 20:48
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@ajwerner ajwerner requested a review from knz April 4, 2023 20:48
@ajwerner ajwerner added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Apr 4, 2023
@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Apr 4, 2023

Relates to #100552.

Copy link
Copy Markdown
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ajwerner
Copy link
Copy Markdown
Contributor Author

ajwerner commented Apr 4, 2023

Yes failure seems unrelated

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 4, 2023

Build succeeded:

@craig craig bot merged commit 85abcf8 into cockroachdb:master Apr 4, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 4, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-100644 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100666/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade/upgrades: TestMigrationWithFailuresMultipleAltersOnSameColumn failed upgrade/upgrades: TestMigrationWithFailures failed

4 participants