Skip to content

jwtauthccl: unskip TestSubjectReservedUser and TestAudienceCheck#100553

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
rafiss:unskip-TestSubjectReservedUser
Apr 4, 2023
Merged

jwtauthccl: unskip TestSubjectReservedUser and TestAudienceCheck#100553
craig[bot] merged 2 commits intocockroachdb:masterfrom
rafiss:unskip-TestSubjectReservedUser

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Apr 4, 2023

I'm making this commit to see if these tests were failing just because the bazel timeout was too low. I'll run it in CI multiple times before merging, since previously this was only failing in CI.

Update: I ran it 10 times in CI without the test failing.

fixes #100356
fixes #100412

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss rafiss force-pushed the unskip-TestSubjectReservedUser branch 2 times, most recently from d441338 to c6c6687 Compare April 4, 2023 14:47
rafiss added 2 commits April 4, 2023 12:23
I'm making this commit to see if these tests were failing just because
the bazel timeout was too low. I'll run it in CI multiple times before
merging, since previously this was only failing in CI.

Release note: None
@rafiss rafiss force-pushed the unskip-TestSubjectReservedUser branch from c6c6687 to 0a8cbe6 Compare April 4, 2023 16:23
@rafiss rafiss requested review from knz and msbutler April 4, 2023 16:34
@rafiss rafiss marked this pull request as ready for review April 4, 2023 16:34
@rafiss rafiss requested review from a team as code owners April 4, 2023 16:34
Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Apr 4, 2023

tftr!

bors r=knz

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 4, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 4, 2023

Build succeeded:

@craig craig bot merged commit 713eb47 into cockroachdb:master Apr 4, 2023
@yuzefovich
Copy link
Copy Markdown
Member

Just saw TestAudienceCheck flake on 23.1 backport. Do we want to backport this change there too?

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Apr 4, 2023

sure!

blathers backport 23.1

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Apr 4, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 4944537 to blathers/backport-release-23.1-100553: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ccl/jwtauthccl: TestSubjectReservedUser failed jwtauthccl: TestSubjectReservedUser and TestAudienceCheck can hang in similar ways

4 participants