sqlccl: deflake TestGCTenantJobWaitsForProtectedTimestamps#100511
sqlccl: deflake TestGCTenantJobWaitsForProtectedTimestamps#100511craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The tenant server must be shut down before the tenant record is removed; otherwise the tenant's SQL server will self-terminate by calling Stop() on its stopper, which in this case was shared with the parent cluster. Release note: None Co-authored-by: Arul Ajmani <arulajmani@gmail.com> Co-authored-by: adityamaru <adityamaru@gmail.com>
|
This change is |
arulajmani
left a comment
There was a problem hiding this comment.
Good find!
Should we add backport labels as well?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @adityamaru and @DrewKimball)
|
bors r=adityamaru,arulajmani |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-100511 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100519/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Fixes #94808
The tenant server must be shut down before the tenant record is removed; otherwise the tenant's SQL server will self-terminate by calling Stop() on its stopper, which in this case was shared with the parent cluster.
Release note: None