-
Notifications
You must be signed in to change notification settings - Fork 4.1k
sql: fix stmtTraceThreshold for pausable portals #99404
Copy link
Copy link
Open
Labels
A-pausable-portalsIssues related to multiple active portalsIssues related to multiple active portalsC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Team
Description
Since a pausable portal can be re-executed by re-calling connExecutor.ExecStmtInOpenState(), we should better record the trace threshold for all executions.
cockroach/pkg/sql/conn_executor_exec.go
Line 726 in d8ea15c
| stmtTraceThreshold := TraceStmtThreshold.Get(&ex.planner.execCfg.Settings.SV) |
Specifically, now each re-execution will get a fresh budget and we won't include details about the previous executions, only about the last one.
Jira issue: CRDB-25867
Epic CRDB-25183
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-pausable-portalsIssues related to multiple active portalsIssues related to multiple active portalsC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-sql-queriesSQL Queries TeamSQL Queries Team
Type
Projects
Status
Backlog