98695: logictest: use v22_2 schema in mixed version test r=JeffSwenson a=JeffSwenson Previously, the v22.2-v23.1 mixed version test was using the v22.2 version gate with a v23.1 schema. This caused the alter_table test to fail on PR #98446. The lease protocol only works if the version gates and the schema are in sync. As part of this change I simplified the version configuration in the logic tests so that the only version key is the bootstrap version. It doesn't really make sense to specify a binary version different than the build version. The binary will always have the build version's behavior. This change also deletes the local-v1.1-at-v1.0-noupgrade test. The version can't be described by a version key and the tests do not represent a situation that occurs in real world deployments. Part of #94843 Release note: None 98697: sql: make sure mixed version logic tests are enabled for declarative schema changer enabled DDL in 22.2 r=chengxiong-ruan a=chengxiong-ruan Informs: #98637 This PR makes sure we enable mixed version logic tests for ddl statements enabled in declarative schema changer in 22.2. We already have mixed version test coverage for `CREATE INDEX`, `DROP INDEX`, `ADD COLUMN`, `DROP COLUMN` and `ADD CONSTRAINT`. Each commit turns on mixed version logic test for each of `DROP OWNED BY`, `COMMENT ON` and `ALTER PRIMARY KEY`. 98711: storage,kv: reenable rewrite concurrency and add format error checking r=jbowens a=sumeerbhola Epic: none Fixes: #97076 Release note: None Co-authored-by: Jeff <swenson@cockroachlabs.com> Co-authored-by: Chengxiong Ruan <chengxiongruan@gmail.com> Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com>

schema: Ensure mixed version logic tests for 22.2 and 23.1 #98637

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions