backupccl: duplicate Files in the BackupManifest result in a pebble SSTWriter error #97953
Description
In #97210 we moved Files, Descriptors and DescriptorChanges out of the backup manifest and into external SSTs written along with the manifest. If there are duplicate Files in the BackupManifest then the backup job fails with:
failed to write backup metadata Files SST: pebble: keys must be added in strictly increasing order: "\x12\xf6\xac\x89\xf7\x039\x88\x00\x01\x12data/844510561971896324.sst\x00\x01"/0,0#0,SET, "\x12\xf6\xac\x89\xf7\x039\x88\x00\x01\x12data/844510561971896324.sst\x00\x01"/0,0#0,SET
More details will be added to this issue as the investigation continues. Note, this feature is feature flagged and default off in release-22.2 so we do not expect it to affect existing customer backups.
Jira issue: CRDB-24983
Epic CRDB-21944
Metadata
Metadata
Assignees
Labels
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Used to mark GA and release blockers, technical advisories, and bugs for 22.2Used to mark GA and release blockers, technical advisories, and bugs for 23.1Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.