-
Notifications
You must be signed in to change notification settings - Fork 4.1k
server: tenant server is left dangling on error #97661
Copy link
Copy link
Closed
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-multitenantIssues owned by the multi-tenant virtual teamIssues owned by the multi-tenant virtual teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1
Description
I think if startTenantServerInternal returns both a server and an error, which can happen at least here, then we'll ignore the server here and then we retry the server creation at a higher level, here. I think we're supposed to stop the new server, as this comment says. Generally, I'm not sure that attempting to recover from a tenant server failing to start is possible / sane.
I may well be missing something.
Jira issue: CRDB-24807
Epic: CRDB-23559
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-multitenantIssues owned by the multi-tenant virtual teamIssues owned by the multi-tenant virtual teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.branch-release-23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1Used to mark GA and release blockers, technical advisories, and bugs for 23.1