Skip to content

kvserver: audit fatal assertions and downgrade some to test builds only #94979

Open
Open
kvserver: audit fatal assertions and downgrade some to test builds only#94979
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV Teamquality-fridayA good issue to work on on Quality Friday
@tbg

Description

@tbg
tbg
opened on Jan 10, 2023

We have a number of assertions in production builds that will crash the node. This is often worse than the problem they're trying to prevent. We should, by default, place assertions behind buildutil.CrdbTestBuild.

See #94825 (comment) for an example.

Jira issue: CRDB-23255

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV Teamquality-fridayA good issue to work on on Quality Friday

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions