93760: sql: implement fine-grained transaction error redaction r=abarganier a=dhartunian Previously, transaction errors would be redacted in full since there was no redaction implemented for their internals. This commit updates all the errors defined in pkg/roachpb/errors.proto to implement `SafeErrorFormatter` in order to be properly redacted. The tests in place are checking to see that redaction markers *do not* appear in the logs. They will be in place when Errors contain redacted values such as Keys containing row data. An additional test was added to the telemetry logging suite to ensure that these errors are surfaced unredacted in telemetry logs as well. Some message fields in Error protobufs have been updated to use `RedactedString` to better support fine grained redaction. A simple migration was applied for those fields but further work may be necessary for further improvements. Epic: CRDB-12732 Resolves: CRDB-14087 Release note (ops change): Transaction errors will contain more detailed information in redacted logs. 95211: logictest: increase timeout for listenurl file r=rail a=rafiss fixes #94956 fixes #94871 Release note: None Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>

logic: TestLogic_testserver_upgrade_node flaked #94956

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions