Skip to content

multitenant: handle descriptor removal in updateNodeAddress, updateStoreMap #93348

Open
Open
multitenant: handle descriptor removal in updateNodeAddress, updateStoreMap#93348
Labels
A-multitenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV Team
@ecwall

Description

@ecwall
ecwall
opened on Dec 9, 2022

These comments indicate that descriptors are added and updated but never removed.

cockroach/pkg/ccl/kvccl/kvtenantccl/connector.go

Line 305 in 1144e9a

// TODO(nvanbenschoten): this doesn't handle NodeDescriptor removal from the

cockroach/pkg/ccl/kvccl/kvtenantccl/connector.go

Line 325 in 1144e9a

// TODO(nvanbenschoten): this doesn't handle StoreDescriptor removal from the

Node count is used in this PR and it will be incorrect if nodes are removed.
#93325

Jira issue: CRDB-22278
Epic: CRDB-26091

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-multitenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV Team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions