Skip to content

storage: include range key info in ScanStats #93326

Closed
#94345
Closed
storage: include range key info in ScanStats#93326
#94345
Assignees
jbowens
Labels
A-storageRelating to our storage engine (Pebble) on-disk storage.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-storageStorage Team
@erikgrinaker

Description

@erikgrinaker
erikgrinaker
opened on Dec 9, 2022

The roachpb.ScanStats struct contains scan statistics that are attached to BatchResponses for observability purposes. This should include information about range keys as well, which will require corresponding changes to pebble.IteratorStats.

cockroach/pkg/storage/mvcc.go

Lines 3556 to 3559 in 19f2fad

KeyBytes: stats.InternalStats.KeyBytes,
ValueBytes: stats.InternalStats.ValueBytes,
PointCount: stats.InternalStats.PointCount,
PointsCoveredByRangeTombstones: stats.InternalStats.PointsCoveredByRangeTombstones,

Jira issue: CRDB-22275

Metadata

Metadata

Assignees

Labels

A-storageRelating to our storage engine (Pebble) on-disk storage.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-storageStorage Team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions