Skip to content

kvserver: sep-raft-log: extract and test replica destruction engine logic #93241

@tbg

Description

@tbg

We should extract the interactions with the engine in destroyRaftMuLocked1 into a standalone method.
We should clarify which operation occurs on which engine in which order.
We need to document the invariants being upheld and how to recover them in the event of an ill-timed crash.

Epic: CRDB-220

Jira issue: CRDB-22234

Footnotes

  1. https://github.com/cockroachdb/cockroach/blob/d5b3fe7c91e1da9745b337e66ad26c776fde0aee/pkg/kv/kvserver/replica_destroy.go#L141-L189

Metadata

Metadata

Assignees

Labels

C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV Team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions