-
Notifications
You must be signed in to change notification settings - Fork 4.1k
storage: MVCCGetWithValueHeader not inlined in MVCCGet #93154
Copy link
Copy link
Closed
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerbranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
Describe the problem
In #89477, we're introducing MVCCGetWithValueHeader. Unfortunately, this is called from MVCCGet and the call there is not inlined, which could have a performance penalty since it's a hot code path. We should check and potentially optimize further.
To Reproduce
Add // gcassert:inline to MVCCValueHeader and run the lints (unfortunately can't run them locally)
Jira issue: CRDB-22190
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerbranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.