Skip to content

storage: MVCCGetWithValueHeader not inlined in MVCCGet #93154

@tbg

Description

@tbg

Describe the problem

In #89477, we're introducing MVCCGetWithValueHeader. Unfortunately, this is called from MVCCGet and the call there is not inlined, which could have a performance penalty since it's a hot code path. We should check and potentially optimize further.

To Reproduce

Add // gcassert:inline to MVCCValueHeader and run the lints (unfortunately can't run them locally)

Jira issue: CRDB-22190

Metadata

Metadata

Assignees

Labels

C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)GA-blockerbranch-masterFailures and bugs on the master branch.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions