-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kv: support SKIP LOCKED and different lock strengths with COL_BATCH_RESPONSE scan format #92950
Copy link
Copy link
Open
Labels
C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.T-kvKV TeamKV TeamT-sql-queriesSQL Queries TeamSQL Queries Team
Description
When implementing the projection pushdown into the KV (#82323), at least initially, we won't support SKIP LOCKED waiting policy. The difficulty with that feature is that it uses roachpb.ResponseKeyIterate function over the keys that are included into the BatchResponse. However, with COL_BATCH_RESPONSE format, we don't have an easy way to access (nor to reconstruct) the original key because we only send the "needed" columns.
For a similar reason (we need to decode keys in acquireUnreplicatedLocksOnKeys), we won't support any lock strength other than lock.None.
Jira issue: CRDB-22064
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-cleanupTech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.C-performancePerf of queries or internals. Solution not expected to change functional behavior.Perf of queries or internals. Solution not expected to change functional behavior.T-kvKV TeamKV TeamT-sql-queriesSQL Queries TeamSQL Queries Team
Type
Projects
Status
Backlog