-
Notifications
You must be signed in to change notification settings - Fork 4.1k
multitenant: replace EXPERIMENTAL_RELOCATE StoreID to NodeID lookup #91628
Copy link
Copy link
Closed
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Description
Currently tenants do not have gossip setup:
cockroach/pkg/server/tenant.go
Line 883 in d6ae965
| gossip: gossip.MakeOptionalGossip(nil), |
When bypassing the UnsupportedWithMultiTenancy error here,
errorutil.UnsupportedWithMultiTenancy (tenant.go:23) github.com/cockroachdb/cockroach/pkg/util/errorutil
errorutil.TenantSQLDeprecatedWrapper.OptionalErr (tenant_deprecated_wrapper.go:79) github.com/cockroachdb/cockroach/pkg/util/errorutil
gossip.OptionalGossip.OptionalErr (gossip.go:1684) github.com/cockroachdb/cockroach/pkg/gossip
sql.lookupStoreDesc (relocate.go:181) github.com/cockroachdb/cockroach/pkg/sql
sql.(*relocateNode).Next (relocate.go:102) github.com/cockroachdb/cockroach/pkg/sql
sql.(*planNodeToRowSource).Next (plan_node_to_row_source.go:204) github.com/cockroachdb/cockroach/pkg/sql
colexec.(*Columnarizer).Next (columnarizer.go:242) github.com/cockroachdb/cockroach/pkg/sql/colexec
colflow.(*batchInfoCollector).next (stats.go:116) github.com/cockroachdb/cockroach/pkg/sql/colflow
<autogenerated>:2
colexecerror.CatchVectorizedRuntimeError (error.go:92) github.com/cockroachdb/cockroach/pkg/sql/colexecerror
colflow.(*batchInfoCollector).Next (stats.go:124) github.com/cockroachdb/cockroach/pkg/sql/colflow
colflow.(*BatchFlowCoordinator).nextAdapter (flow_coordinator.go:252) github.com/cockroachdb/cockroach/pkg/sql/colflow
<autogenerated>:2
colexecerror.CatchVectorizedRuntimeError (error.go:92) github.com/cockroachdb/cockroach/pkg/sql/colexecerror
colflow.(*BatchFlowCoordinator).next (flow_coordinator.go:256) github.com/cockroachdb/cockroach/pkg/sql/colflow
colflow.(*BatchFlowCoordinator).Run (flow_coordinator.go:299) github.com/cockroachdb/cockroach/pkg/sql/colflow
colflow.(*vectorizedFlow).Run (vectorized_flow.go:320) github.com/cockroachdb/cockroach/pkg/sql/colflow
sql.(*DistSQLPlanner).Run (distsql_running.go:688) github.com/cockroachdb/cockroach/pkg/sql
sql.(*DistSQLPlanner).PlanAndRun (distsql_running.go:1553) github.com/cockroachdb/cockroach/pkg/sql
sql.(*DistSQLPlanner).PlanAndRunAll (distsql_running.go:1305) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execWithDistSQLEngine (conn_executor_exec.go:1572) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).dispatchToExecutionEngine (conn_executor_exec.go:1214) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execStmtInOpenState (conn_executor_exec.go:723) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execStmt.func1 (conn_executor_exec.go:127) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execWithProfiling (conn_executor_exec.go:2417) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execStmt (conn_executor_exec.go:126) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execCmd.func1 (conn_executor.go:1927) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).execCmd (conn_executor.go:1932) github.com/cockroachdb/cockroach/pkg/sql
sql.(*connExecutor).run (conn_executor.go:1852) github.com/cockroachdb/cockroach/pkg/sql
sql.(*Server).ServeConn (conn_executor.go:830) github.com/cockroachdb/cockroach/pkg/sql
pgwire.(*conn).processCommandsAsync.func1 (conn.go:728) github.com/cockroachdb/cockroach/pkg/sql/pgwire
runtime.goexit (asm_amd64.s:1594) runtime
- Async Stack Trace
pgwire.(*conn).processCommandsAsync (conn.go:639) github.com/cockroachdb/cockroach/pkg/sql/pgwire
there is a failure because g is nil:
Line 185 in d6ae965
| if err := g.GetInfoProto( |
Jira issue: CRDB-21356
Epic CRDB-16746
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-multitenancyRelated to multi-tenancyRelated to multi-tenancyC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)