-
Notifications
You must be signed in to change notification settings - Fork 4.1k
descs: extend uncommitted layer beyond descriptors #88571
Copy link
Copy link
Closed
Labels
A-schema-catalogRelated to the schema descriptors collection and the catalog API in general.Related to the schema descriptors collection and the catalog API in general.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Description
The descs.Collection should mediate and maintain in-memory changes not just to descriptors, but also to anything joining on descriptors:
- namespace entries,
- zone configs,
- comments,
- is there anything else? idk.
This implies also caching in the stored layer, plumbing the reads of these new system tables into catkv.catalogQuerier, adding and adopting more accessor methods on the Collection, etc.
We can then get rid of the MetadataUpdater, CommentCache etc. interfaces and implementations.
At that point it should also be trivial to extend nstree.Catalog to include zone configs and comments.
Jira issue: CRDB-19972
Epic CRDB-19158
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-schema-catalogRelated to the schema descriptors collection and the catalog API in general.Related to the schema descriptors collection and the catalog API in general.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)SQL Foundations Team (formerly SQL Schema + SQL Sessions)